Feature #24
closedEpic #20: Client design adaptation
Adapt Foods filtering to the shared bottom-sheet interaction
0%
Description
Imported from GitHub issue 266.
Source milestone: Redesign (milestone 3).
Source labels: enhancement, ready-for-agent.
Original state: closed.
What to build¶
Type: AFK
Deliver the complete new Foods filtering flow and establish reusable filter controls and draft/applied state handling for Recipes and Guides. Replace inline filter rows with the Figma bottom sheet while keeping search visible. Update the domain documentation to replace immediate inline filtering with the agreed interaction contract.
Use only the Design and Design tokens pages of https://www.figma.com/design/yisgB7iNKYtjNZdogARGIN/Bebin-prvi-meni. Exclude the reference-app page entirely. The food sheet is the visual source; recipe and guide sheets adapt its shared pattern while preserving their domain rules.
Use existing theme, typography and pressable infrastructure. Check the required Expo 57 documentation before coding. Keep catalogue-specific matching in repositories rather than coupling it to shared UI.
Acceptance criteria¶
- Search remains visible and debounced; search combines with applied filter groups using AND semantics.
- Opening Filter copies applied selections into a draft. Editing a draft updates its preview count without changing catalogue results.
- Apply commits the draft, closes the sheet, and resets pagination and scroll position. Close, backdrop dismissal, Android Back and any supported drag dismissal discard pending changes.
- Reset clears draft selections and requires Apply to commit. A separate clear-all action clears search, applied selections and any removable context filters; it is hidden when nothing is active.
- The Filter button indicates the number of applied selections, excluding search; each selected category or non-default age/sub-section counts as one selection.
- Counts include all matching public catalogue records, including locked previews, rather than only loaded result pages. Count predicates match list predicates, reuse the content cache, and never fetch protected details.
- Count loading and failures have explicit states and retry; no partial or failed count is presented as an exact total. Stale list/count responses cannot overwrite newer selections, locale or content revisions.
- Serbian Latin and English fixed copy is complete; content labels, sorting and search preserve locale fallback rules.
- Back-navigation from details and access flows preserves list context. Section re-entry and active-tab reselection reset temporary state according to the domain rules; no cross-session persistence is introduced.
- No-content and no-results states remain distinct; no-results provides a direct clear-all action.
- Automated tests cover draft/apply/cancel/reset, matching/count consistency, stale requests and pagination where applicable. Client tests, lint and typecheck pass.
- Food categories remain multi-select: selected categories form an OR group; category, search and age groups combine with AND. No selected categories means all categories.
- Age remains single-select with existing all/6/9/12 threshold semantics, including existing handling of missing age metadata; no baby-profile personalisation is introduced.
- Options use actual category IDs, localized labels and content order; the six Figma groups are examples, not a replacement taxonomy. No new allergen or access-tier filtering is introduced.
- Home category-progress navigation opens Foods with the category already applied; opening and cancelling the sheet preserves that selection.
- Shared controls provide a scrollable sheet, fixed actions, safe-area handling, keyboard dismissal and accessible selected states, using the Figma 44 px chips and 52 px actions as design references.
- Android acceptance is demonstrated through the ADB-connected device, covering selection, count, dismissal, reset, keyboard, long labels, empty results, and detail/access-flow return. Capture comparison evidence against permitted Figma sources.
Blocked by¶
None - can start immediately
Acceptance verification¶
All 17 criteria checked against PR GitHub 274 at e82ec48 and the recorded implementation, automated and native evidence. The PR remains open; this checklist records verified implementation rather than a merge or release.
- Current acceptance report and original issue-specific device evidence.
- Client: 466 tests in 63 files, typecheck and lint passed. Contracts: 57 tests in two files passed. Android build/install and ADB verification passed. These are the recorded checks for this commit; no new CI run is implied.
- ADB verified localised ordering, exact counts, applied context, foreground scroll retention and access-screen return. Sign-in/Premium screens were entered using deep links while retaining the existing Premium account, then dismissed with Cancel/Android Back. OAuth provider-picker cancellation, purchase-sheet cancellation and a real guest account session are outside that native evidence; locked-preview destinations/badges also have automated and fixture coverage.
- iOS acceptance remains tracked separately in GitHub 269.
No data to display