Project

General

Profile

Actions

Feature #58

closed
VJ

Epic #20: Client design adaptation

Adapt Home welcome and section-entry cards to Figma

Feature #58: Adapt Home welcome and section-entry cards to Figma

Added by Vince Jurić 11 days ago.

Status:
Done
Priority:
Normal
Assignee:
-
Start date:
Due date:
% Done:

0%

Estimated time:

Description

Imported from GitHub issue 290.
Source milestone: Milestone 3.
Source labels: enhancement, ready-for-agent.
Original state: closed.

What to build

Deliver a polished Home welcome and four prominent section-entry cards for Meal Plans, Foods, Recipes and Guides, replacing the placeholder mobile-shell presentation and copy. Cards open section root surfaces using existing navigation behaviour. This slice includes implementation, localisation, behavioural coverage and Android presentation verification.

Design sources and scope

Use only the Design and Design tokens pages in https://www.figma.com/design/yisgB7iNKYtjNZdogARGIN/Bebin-prvi-meni. Home references: Guest 69:719, signed-in free 75:4348, Premium 75:6369. Exclude the reference-app page entirely.

Adapt presentation while preserving the current domain and ADRs: Home remains Početna / Home; no baby-age collection, personalisation, daily dashboard, content feeds, global selected plan or per-meal completion. Retain the shared header and bottom tabs without duplicating the design's content header. Reuse existing tokens, typography and controls. Reference layout: 390-unit width, 20-unit gutters and 24-unit section spacing; adapt to device width and text scaling.

Acceptance criteria

  • Home welcome and four section-entry cards use the approved Figma visual language and existing theme tokens.
  • Placeholder mobile-shell copy is replaced with production copy in Serbian Latin and English; Serbian uses ekavian wording and established product terms.
  • Cards navigate to section roots without preselected ages, searches or filters; bottom-tab root reset behaviour is preserved.
  • Shared header/profile action and bottom navigation remain functional, with no duplicate header.
  • Narrow portrait screens and enlarged text reflow without overlap or clipped actions; controls have accessible labels and adequate touch targets.
  • Navigation behaviour is covered by meaningful tests; client tests, type checking and lint pass.
  • Android verification covers both locales, normal and enlarged text, and reference/narrow widths, with recorded evidence.

Blocked by

None - can start immediately.

Execution type

AFK — ready for an agent.

Acceptance review — 2 November 2026

Six of seven criteria are checked. No actionable code defects were found in the current implementation review. A fresh client run passed 75 Vitest files / 608 tests, Node release/changelog guards, type checking and lint. The recorded ADB evidence covers both locales at approximately 390/320 logical-unit widths and normal/150% font scale, all four root destinations, Foods search reset, meal-plan age-root re-entry, Profile return and Home tab scroll reset.

Criterion 5 remains open pending a direct on-device visual check for overlap/clipping at those configurations. The native accessibility tree supports labelled/focusable controls and scroll reachability, but viewport-clipped bounds cannot prove the complete rendered appearance. Screen-capture protection remains enabled and produced black app screenshots. Spoken TalkBack output also remains unaudited.

The welcome and four-entry grid are the approved product-domain adaptation for this issue, not a composition present verbatim in a Figma frame. Theme tokens and typography follow the permitted product design sources. The acceptance report and raw evidence are currently in the uncommitted working tree under docs/home-welcome-entry-acceptance-290.md and docs/evidence/home-290/. This review does not close the issue.

Direct visual inspection — 2 November 2026

ADB screenshots were inspected for English and Serbian Latin at approximately 390 and 320 logical units, font scales 1.0 and 1.5, plus 320 units at 2.0. Screenshots cover the welcome and all four entries across scroll positions. The 320/2.0 captures were repeated with the Expo Tools overlay hidden. The device was signed in during this follow-up; no account/content changes were made.

  • PASS: welcome and entry-card text wraps within its paper surface; no internal text clipping, card-to-card overlap, or overlap with the shared header was observed. At narrow/enlarged settings the entries use one column. Partial cards at the scroll viewport boundaries scroll fully into view.
  • DEFECT (shared bottom navigation): at 320 units/1.0, Meal Plans and Namirnice truncate. At 390/1.5, Meal Plans and Namirnice truncate; Serbian labels crowd together. At 320/1.5 and 320/2.0, several labels truncate and adjacent labels visibly run together in both locales. Reproduce by setting density 610 and font scale 1.5, then opening Home. The existing single-line bottom-tab layout in apps/client/app/(tabs)/_layout.tsx needs a responsive label treatment.

Criterion 5 remains unchecked because of this observed shared-navigation defect, rather than lack of visual access. The welcome/entry-card portion passes direct visual inspection. Spoken TalkBack output remains unverified. Evidence: docs/evidence/home-290/visual-{locale}-{density}-{fontScale}-{scrollIndex}.png.

Capture protection was temporarily disabled only for the local development session to enable inspection, using Expo's capture API lifecycle; the exact original source was restored afterwards. Density 450, font scale 1.0 and Serbian Latin were restored. No capture-protection change is included in the implementation.

Final verification — 2 November 2026

All seven acceptance criteria pass. The shared bottom-navigation defect is fixed: labels now wrap within each tab and the bar grows to the tallest measured label for the current locale, width and text scale. Font scaling remains enabled, complete accessibility labels remain on each tab, and normal reference-width styling is retained. At extreme text sizes, long words may wrap across lines within their own tab.

Direct live Android screenshot review passed all ten configurations: English and Serbian Latin at approximately 390/320 logical units with 100%/150% text, plus 320 units with 200% text. No text truncation, internal clipping or overlap was observed in the welcome, entry cards or tab labels. All four entries can be scrolled fully into view. All five bottom tabs were activated at 320/200%; their labelled/focusable controls remained available, and returning to Home restored the welcome.

Final automated checks passed: 75 Vitest files / 609 tests, Node guards, type checking, lint and whitespace validation. Regression coverage verifies that wrapped labels increase bar height and that changing text size recalculates it. Evidence: docs/evidence/home-290/final-verification.json, final-navigation.json, final-nav-*.xml and final-visual-*.png.

Capture protection was restored to its exact original implementation and confirmed active with a black app-region screenshot. Device density 450, font scale 1.0 and Serbian Latin were restored; Home is at the top. Spoken TalkBack output is not claimed as audited; the checklist requires accessible labels/touch targets, which were verified structurally. iOS remains separately tracked in GitHub 293. Changes remain uncommitted; this checklist update does not close GitHub 290. This final result supersedes earlier open-criterion and navigation-defect notes above.

No data to display

Actions

Also available in: PDF Atom